-
Notifications
You must be signed in to change notification settings - Fork 52
CIP-0082 (Daml draft) - 5% development fund impl #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CIP-0082 (Daml draft) - 5% development fund impl #3086
Conversation
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nice work!
wdyt about doing the change wrt where the configs are stored, and then implementing the Daml tests before pinging for another review?
Are you referring to implementing the full Daml test suite to cover all the new scenarios? |
yes |
6569272 to
d3561be
Compare
Done |
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you @jose-velasco-ieu 🙏
Seems like we have everything ready for you to create the short design doc tying these Daml changes toghether with the app changes required.
...ard/splice-token-standard-test/daml/Splice/Testing/Registries/AmuletRegistry/Parameters.daml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
…Coupon collection Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
…velopmentFundCoupon Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
…evelopmentFundCoupon Signed-off-by: Jose Velasco <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
…work with external signing Signed-off-by: Jose Velasco <[email protected]>
… prepare-submission delays larger than 1 minute Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
babd8bc to
acedf35
Compare
📝 PR Summary
This draft PR proposes Daml changes related to CIP-0082 — Establish a 5% Development Fund.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines