Skip to content

Conversation

@jose-velasco-ieu
Copy link
Contributor

@jose-velasco-ieu jose-velasco-ieu commented Nov 5, 2025

📝 PR Summary

This draft PR proposes Daml changes related to CIP-0082Establish a 5% Development Fund.

⚠️ Disclaimer

  • This PR is not production-ready.
  • Pre-commit checks were skipped.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice work!

wdyt about doing the change wrt where the configs are stored, and then implementing the Daml tests before pinging for another review?

@jose-velasco-ieu
Copy link
Contributor Author

and then implementing the Daml tests

Are you referring to implementing the full Daml test suite to cover all the new scenarios?
@meiersi-da

@meiersi-da
Copy link
Contributor

and then implementing the Daml tests

Are you referring to implementing the full Daml test suite to cover all the new scenarios? @meiersi-da

yes

@jose-velasco-ieu
Copy link
Contributor Author

and then implementing the Daml tests

Are you referring to implementing the full Daml test suite to cover all the new scenarios? @meiersi-da

yes

Done
I think it's ready for a second review

Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you @jose-velasco-ieu 🙏

Seems like we have everything ready for you to create the short design doc tying these Daml changes toghether with the app changes required.

jose-velasco-ieu and others added 28 commits December 3, 2025 12:47
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Jose Velasco - IEU <[email protected]>
…work with external signing

Signed-off-by: Jose Velasco <[email protected]>
… prepare-submission delays larger than 1 minute

Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants